Fix the char zero ending panic in native config for streaming #706
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-ionescu
changed the title
This was referenced Aug 7, 2024
andrei-ionescu
force-pushed
the
ai.fix_char_zero_ending
branch
from
5a25da2 to
976d56d
Compare
Contributor
Author
|
@fede1024 Could you have a look into this? It's been more than a year. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the
max.poll.interval.msproperty, that is mandatory in the streaming case (ie:stream-consumer), when retrieving that value from the native config it will receive a zero char ending string which cannot pe parsed intou64leading to panic.Solution is to trim out the zero ending char from the string so that it can be parsed into
u64.